fix: sanitize server-returned text to prevent ANSI escape injection#85
Open
bendavis-stripe wants to merge 1 commit intomainfrom
Open
fix: sanitize server-returned text to prevent ANSI escape injection#85bendavis-stripe wants to merge 1 commit intomainfrom
bendavis-stripe wants to merge 1 commit intomainfrom
Conversation
bendavis-stripe
force-pushed
the
bendavis/fix-ansi-sanitation
branch
5 times, most recently
from
922ffed to
1943e4a
Compare
irace-stripe
reviewed
May 9, 2026
irace-stripe
approved these changes
May 9, 2026
bendavis-stripe
force-pushed
the
bendavis/fix-ansi-sanitation
branch
3 times, most recently
from
f05b754 to
4fd8690
Compare
Server-returned string fields (merchant_name, line_items[].name, billing_address.*, payment method brand/nickname) are now sanitized before rendering in Ink components using strip-ansi plus control character stripping. This prevents terminal escape sequence injection that could spoof the approval UI. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Committed-By-Agent: claude
bendavis-stripe
force-pushed
the
bendavis/fix-ansi-sanitation
branch
from
4fd8690 to
47f29b1
Compare
kreese-stripe
approved these changes
May 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sanitizeText()/sanitizeDeep()utilities usingstrip-ansi+ control character stripping to prevent terminal escape sequence injectionContext
Server-returned string fields (e.g.
merchant_name,line_items[].name) can contain ANSI escape sequences or control characters that manipulate terminal output during the approval flow. Sanitization is applied once at the resource factory boundary viasanitizeResource()— a Proxy wrapper that callssanitizeDeep()on all async method return values. This means all consumers (interactive components, agent/JSON mode, toon format) get clean data without manual per-field wrapping.Test plan
sanitizeText()andsanitizeDeep()covering CSI, OSC, carriage return, control chars, compound payloads, and nested objectsCreateSpendRequest,UpdateSpendRequest,RetrieveSpendRequest, andPaymentMethodsListusingsanitizeResource-wrapped mocks